20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
55 lines
1.9 KiB
TypeScript
Executable File
55 lines
1.9 KiB
TypeScript
Executable File
/**
|
|
* A3 regression: Transaction boundary — repos use (tx?.db ?? this.db)
|
|
* Bug: EventStore passed _tx to repos, but repos ignored it (always used this.db).
|
|
* Fix: all repos use (tx?.db ?? this.db).prepare(...) and TransactionHandle has db field.
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { readFileSync, readdirSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
describe('A3: Transaction boundary fix', () => {
|
|
const repos_dir = join(import.meta.dir, '..', '..', 'src', 'storage', 'repositories')
|
|
|
|
it('TransactionHandle interface includes db field', () => {
|
|
const contracts_src = readFileSync(
|
|
join(import.meta.dir, '..', '..', '..', 'contracts', 'src', 'task.ts'),
|
|
'utf-8'
|
|
)
|
|
expect(contracts_src).toMatch(/db\s*\?\s*:/)
|
|
})
|
|
|
|
it('core CRUD methods in repositories use (tx?.db ?? this.db) pattern', () => {
|
|
const repo_files = readdirSync(repos_dir).filter(f => f.endsWith('.ts') && !f.endsWith('.d.ts'))
|
|
|
|
for (const file of repo_files) {
|
|
const src = readFileSync(join(repos_dir, file), 'utf-8')
|
|
|
|
const crud_methods = ['async get(', 'async insert(', 'async update(']
|
|
for (const method_sig of crud_methods) {
|
|
const idx = src.indexOf(method_sig)
|
|
if (idx === -1) continue
|
|
|
|
const method_body = src.slice(idx, src.indexOf('\n }', idx) + 4)
|
|
if (method_body.includes('this.db.prepare')) {
|
|
expect(method_body).toContain('tx?.db')
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
it('EventStore passes _tx to repository calls in project()', () => {
|
|
const event_store_src = readFileSync(
|
|
join(import.meta.dir, '..', '..', 'src', 'events', 'EventStore.ts'),
|
|
'utf-8'
|
|
)
|
|
|
|
const project_method = event_store_src.match(/project\s*\([^)]*\)[^{]*\{/s)
|
|
expect(project_method).not.toBeNull()
|
|
|
|
const repo_calls = event_store_src.match(/\?\.(?:insert|update|get)\([^)]*,\s*_tx\s*\)/g)
|
|
expect(repo_calls).not.toBeNull()
|
|
expect(repo_calls!.length).toBeGreaterThan(0)
|
|
})
|
|
})
|