82f3140847
Complete architecture document set with multi-model review remediation: - Frozen interface contracts, runtime semantics, DB schemas - Event/tool/error/provider registries - Scheduler and main agent state machines - C4 module/code views, solution architecture, baseline V1 - Multi-model review reports and joint assessment - Phase-gate remediation complete (P0/P1/P2/UX resolved) - Implementation plan with T-000A through T-045 - Reference folders kept as placeholders only
67 lines
3.2 KiB
Markdown
67 lines
3.2 KiB
Markdown
# CI / Review Heuristics
|
||
|
||
## CI classification checklist
|
||
|
||
Treat as **branch-related** when logs clearly indicate a regression caused by the PR branch:
|
||
|
||
- Compile/typecheck/lint failures in files or modules touched by the branch
|
||
- Deterministic unit/integration test failures in changed areas
|
||
- Snapshot output changes caused by UI/text changes in the branch
|
||
- Static analysis violations introduced by the latest push
|
||
- Build script/config changes in the PR causing a deterministic failure
|
||
|
||
Treat as **likely flaky or unrelated** when evidence points to transient or external issues:
|
||
|
||
- DNS/network/registry timeout errors while fetching dependencies
|
||
- Runner image provisioning or startup failures
|
||
- GitHub Actions infrastructure/service outages
|
||
- Cloud/service rate limits or transient API outages
|
||
- Non-deterministic failures in unrelated integration tests with known flake patterns
|
||
|
||
Do not patch likely flaky/unrelated failures. Use the retry budget for rerunnable failures, wait for pending jobs, or stop and report the blocker when the failure is persistent or infrastructure-owned.
|
||
|
||
If uncertain, inspect failed logs once before choosing rerun.
|
||
|
||
## Decision tree (fix vs rerun vs stop)
|
||
|
||
1. If PR is merged/closed: stop.
|
||
2. If there are failed checks:
|
||
- Diagnose first.
|
||
- If checks are still pending but an individual job has already failed: fetch that job's logs and diagnose now.
|
||
- If branch-related: fix locally, commit, push.
|
||
- If likely flaky/unrelated and all checks for the current SHA are terminal: rerun failed jobs.
|
||
- If likely flaky/unrelated and not safely rerunnable: stop and report the blocker; do not edit unrelated tests, build scripts, CI configuration, dependency pins, or infrastructure code.
|
||
- If checks are still pending and no failed job is available yet: wait.
|
||
3. If flaky reruns for the same SHA reach the configured limit (default 3): stop and report persistent failure.
|
||
4. Independently, process any new human review comments.
|
||
|
||
## Review comment agreement criteria
|
||
|
||
Address the comment when:
|
||
|
||
- The comment is technically correct.
|
||
- The change is actionable in the current branch.
|
||
- The requested change does not conflict with the user’s intent or recent guidance.
|
||
- The change can be made safely without unrelated refactors.
|
||
|
||
Fix valid human review feedback in code when possible, but do not post a GitHub reply to a human-authored comment/thread unless the user explicitly confirms the exact response.
|
||
|
||
Do not auto-fix when:
|
||
|
||
- The comment is ambiguous and needs clarification.
|
||
- The request conflicts with explicit user instructions.
|
||
- The proposed change requires product/design decisions the user has not made.
|
||
- The codebase is in a dirty/unrelated state that makes safe editing uncertain.
|
||
- The comment only needs a written answer or disagreement response; propose the reply to the user instead of posting it automatically.
|
||
|
||
## Stop-and-ask conditions
|
||
|
||
Stop and ask the user instead of continuing automatically when:
|
||
|
||
- The local worktree has unrelated uncommitted changes.
|
||
- `gh` auth/permissions fail.
|
||
- The PR branch cannot be pushed.
|
||
- CI failures persist after the flaky retry budget.
|
||
- Reviewer feedback requires a product decision or cross-team coordination.
|
||
- A human review comment requires a written GitHub reply instead of a code change.
|