feat: AirPlan V2 — 全专家插件强制路由 + 事件系统规范化
P0-8 扩大: do_mode.py finish_worker 全专家插件强制路由 - GUI→XDB, network→NDB, C/C++→SDB, done→Rvr, blocked/failed→Dbg - 证据去重: 已有 xdbSessions/ndbSessions/sdbReports/rvrReviewed 则跳过 P1-GAP17: 事件 emit 规范化 - 新增 7 个事件常量 (TASK_ENTERED, TASK_FINISHED, ENGINE_ENTERED 等) - 全部 emit 调用替换字符串字面量为常量,零残留 - 30 个事件类型常量全部定义且唯一 P1-GAP18: 事件日志原子轮转 - emit 计数器每 128 次检查轮转,避免每次 emit 读文件 - 清除未使用的 _emit_with_completion/_pending_merge_complete - 原子轮转: tempfile+os.replace 保证不损坏 eng 极端接管: 强制调用全部专家插件 (Dbg/XDB/NDB/SDB/Rvr) commands/do.md: 更新为全专家插件路由文档 全量测试: 69 通过, 0 失败 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
53
commands/rvr.md
Executable file
53
commands/rvr.md
Executable file
@@ -0,0 +1,53 @@
|
||||
---
|
||||
description: "AirPlan rvr mode - requirement reviewer with highRiskAudit and code-to-design"
|
||||
argument-hint: "[review|status]"
|
||||
allowed-tools: "[Read, Glob, Grep, Bash, Write, Edit]"
|
||||
---
|
||||
|
||||
# /rvr
|
||||
|
||||
AirRvr 是需求审查器。基于原始需求文档对已完成任务进行独立审查,验证交付物与需求的一致性。含 highRiskAudit(生命周期/空指针/悬垂指针/异常安全/并发)和 Code-to-Design 逐行对照。
|
||||
|
||||
## 硬规则
|
||||
|
||||
1. **code-to-design 对照** — 每次审查必须逐行对照代码实现与设计文档(ADR、C4、需求)
|
||||
2. **高风险审计** — 终审必须包含 lifecycle/nullPointer/danglingPointer/exceptionSafety/concurrency 五项检查
|
||||
3. **verdict 控制合并** — fail 阻止合并,conditional-pass 记录遗留项,pass 正常合并
|
||||
4. **deliveryVerdict = block-release** — eng dispatch 阻止所有后续派发
|
||||
|
||||
## 审查模式
|
||||
|
||||
| 模式 | 触发时机 | 审查范围 |
|
||||
|------|---------|---------|
|
||||
| per-task | 单个任务完成后 | 单任务 |
|
||||
| per-wave | 波次所有任务完成后 | 整波 |
|
||||
| per-milestone | 项目阶段结束时 | 全量(比对 requirements.md) |
|
||||
|
||||
## 子命令
|
||||
|
||||
### review — 执行审查
|
||||
|
||||
```bash
|
||||
python scripts/airplan.py --mode rvr --project . --sub review --task-id T-001
|
||||
```
|
||||
|
||||
返回 `{task_id, verdict, report_path}`。审查报告含 coverage/intentAlignment/regressionRisk/codeQuality/lifecycleHealth/runtimeStability/codeToDesignTable/highRiskAudit。
|
||||
|
||||
制品:`AirPlan/state/airrvr/reviews/{task_id}-{ts}.json`
|
||||
|
||||
### status — 查看审查状态
|
||||
|
||||
```bash
|
||||
python scripts/airplan.py --mode rvr --project . --sub status
|
||||
```
|
||||
|
||||
## 集成路径
|
||||
|
||||
**Eng merge 时自动检查**:merge_worker_result Phase 1.5 自动调用 `get_verdict_for_task(task_id)`:
|
||||
- `verdict=fail` → 抛出 `ValueError` 阻止合并
|
||||
- `verdict=conditional-pass` → 记录 residualItems 但允许合并
|
||||
- `deliveryVerdict=block-release` → dispatch_worker_group 阻止所有后续派发
|
||||
|
||||
**触发方式**:设置 `reviewPolicy.requireBeforeMerge=true` 或在 result 中设 `requireReview=true`。
|
||||
|
||||
**INVALIDATED 任务清理检查**(P1-21):ADR 变更级联失效后,手动调 `check_invalidated_cleanup()` 验证旧代码已清理。
|
||||
Reference in New Issue
Block a user