20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
47 lines
1.6 KiB
TypeScript
Executable File
47 lines
1.6 KiB
TypeScript
Executable File
/**
|
|
* A1 regression: command injection fix — execFileSync, not execSync
|
|
* Verifies CMakeConfigurator, CppBuilder, CppcheckRunner use execFileSync.
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
const SRC_ROOT = join(import.meta.dir, '..', 'src')
|
|
|
|
function reads_file(relative: string): string {
|
|
return readFileSync(join(SRC_ROOT, relative), 'utf-8')
|
|
}
|
|
|
|
describe('A1: Command injection fix', () => {
|
|
it('CMakeConfigurator uses execFileSync, not execSync', () => {
|
|
const src = reads_file('build/CMakeConfigurator.ts')
|
|
expect(src).toContain('execFileSync')
|
|
expect(src).not.toMatch(/\bexecSync\s*\(/)
|
|
})
|
|
|
|
it('CppBuilder uses execFileSync, not execSync', () => {
|
|
const src = reads_file('build/CppBuilder.ts')
|
|
expect(src).toContain('execFileSync')
|
|
expect(src).not.toMatch(/\bexecSync\s*\(/)
|
|
})
|
|
|
|
it('CppcheckRunner uses execFileSync, not execSync', () => {
|
|
const src = reads_file('analysis/CppcheckRunner.ts')
|
|
expect(src).toContain('execFileSync')
|
|
expect(src).not.toMatch(/\bexecSync\s*\(/)
|
|
})
|
|
|
|
it('CMakeConfigurator passes args as array to execFileSync', () => {
|
|
const src = reads_file('build/CMakeConfigurator.ts')
|
|
expect(src).toMatch(/execFileSync\s*\(\s*'cmake'/)
|
|
expect(src).not.toMatch(/execFileSync\s*\(\s*'cmake'\s*,\s*[`'"]/)
|
|
})
|
|
|
|
it('CppBuilder passes args as array to execFileSync', () => {
|
|
const src = reads_file('build/CppBuilder.ts')
|
|
expect(src).toMatch(/execFileSync\s*\(\s*'cmake'/)
|
|
expect(src).not.toMatch(/execFileSync\s*\(\s*'cmake'\s*,\s*[`'"]/)
|
|
})
|
|
})
|