Files
AirCoding/packages/runtime/src/storage/repositories/TaskDependencyRepository.ts
AirCoding 20bad8ca29 fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED:
- B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck)
- B6: ToolRegistry permission bypass fixed (real task_scope/profile passed)
- B7: ACTION_BRANCHES this-binding crash fixed (instance method)
- B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key)
- B22: CommandRiskAnalyzer 'in' operator bug fixed (includes)
- B1: EventStore.project() transaction handle now passed to all repos
- B2: workspace projection illegal enum fixed (active/merged)
- B4: route_prefix separator unified to '/'
- B5: TaskAttempt column mapping fixed

Other blockers fixed:
- B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories)
- B9: cpp.* tools registered through PermissionEngine path
- B11: Scheduler BLOCKED/CANCELLED states added
- B18: CapabilityTrustLevel 5-level enum aligned
- B19: PermissionEngine block/refuse/announce_then_run + grant_scope
- B20: Worker exit code 4 = parent_cancelled
- B24: project_id now randomUUID

Regression fix (introduced by B3 schema refactor):
- wiring.ts capture_debug_record/promote_memory_entry realigned to
  refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling)

Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites)

Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler
event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields),
B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real),
B25 (MVP tools), B26 (ContextAssembler L6-L9)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-03 13:13:27 +08:00

144 lines
4.3 KiB
TypeScript
Executable File

/**
* TaskDependencyRepository - CRUD + list_for_task, list_dependents for task_dependencies table (§8)
*
* Implements Repository<TaskDependencyRecord, TaskDependencyInsert, TaskDependencyUpdate>
* per contracts §6.
*
* @module packages/runtime/src/storage/repositories/TaskDependencyRepository
*/
import type {
Repository,
TransactionHandle,
SessionID,
TaskID,
UUID,
ISOTimeString,
} from '@aircoding/contracts'
import { DatabaseHandle } from '../MigrationRunner.js'
import { assertEnumValues } from '../assertEnum.js'
// =============================================================================
// Types - per db-schema §8
// =============================================================================
export type TaskDependencyType = 'hard' | 'soft' | 'conflict' | 'serialization'
export interface TaskDependencyRecord {
id: UUID
session_id: SessionID
task_id: TaskID
depends_on_task_id: TaskID
dependency_type: TaskDependencyType
reason?: string
created_at: ISOTimeString
}
export type TaskDependencyInsert = Omit<TaskDependencyRecord, 'id'> & {
id?: UUID
}
export type TaskDependencyUpdate = Partial<Omit<TaskDependencyRecord, 'id' | 'session_id' | 'task_id' | 'depends_on_task_id' | 'created_at'>>
// =============================================================================
// TaskDependencyRepository
// =============================================================================
export class TaskDependencyRepository implements Repository<TaskDependencyRecord, TaskDependencyInsert, TaskDependencyUpdate> {
private db: DatabaseHandle
constructor(db: DatabaseHandle) {
this.db = db
}
/**
* Get a task dependency by ID.
*/
async get(id: UUID, tx?: TransactionHandle): Promise<TaskDependencyRecord | undefined> {
const stmt = (tx?.db ?? this.db).prepare('SELECT * FROM task_dependencies WHERE id = ?')
const row = stmt.get(id) as TaskDependencyRecord | undefined
return row
}
/**
* Insert a new task dependency.
*/
async insert(record: TaskDependencyInsert, tx?: TransactionHandle): Promise<void> {
// Validate enum columns
assertEnumValues('task_dependencies', {
dependency_type: record.dependency_type,
})
const stmt = (tx?.db ?? this.db).prepare(`
INSERT INTO task_dependencies (
id, session_id, task_id, depends_on_task_id,
dependency_type, reason, created_at
) VALUES (?, ?, ?, ?, ?, ?, ?)
`)
stmt.run(
record.id,
record.session_id,
record.task_id,
record.depends_on_task_id,
record.dependency_type,
record.reason ?? null,
record.created_at,
)
}
/**
* Update an existing task dependency.
*/
async update(id: UUID, patch: TaskDependencyUpdate, tx?: TransactionHandle): Promise<void> {
// Validate enum columns if present
if (patch.dependency_type !== undefined) {
assertEnumValues('task_dependencies', { dependency_type: patch.dependency_type })
}
const fields: string[] = []
const values: unknown[] = []
if (patch.dependency_type !== undefined) {
fields.push('dependency_type = ?')
values.push(patch.dependency_type)
}
if (patch.reason !== undefined) {
fields.push('reason = ?')
values.push(patch.reason)
}
if (fields.length === 0) {
return // Nothing to update
}
values.push(id)
const stmt = (tx?.db ?? this.db).prepare(`UPDATE task_dependencies SET ${fields.join(', ')} WHERE id = ?`)
stmt.run(...values)
}
// =============================================================================
// Extra methods
// =============================================================================
/**
* List all dependencies for a task (what this task depends on).
*/
async list_for_task(task_id: TaskID): Promise<TaskDependencyRecord[]> {
const stmt = this.db.prepare(
'SELECT * FROM task_dependencies WHERE task_id = ? ORDER BY created_at ASC',
)
return stmt.all(task_id) as TaskDependencyRecord[]
}
/**
* List all dependents of a task (tasks that depend on this one).
*/
async list_dependents(depends_on_task_id: TaskID): Promise<TaskDependencyRecord[]> {
const stmt = this.db.prepare(
'SELECT * FROM task_dependencies WHERE depends_on_task_id = ? ORDER BY created_at ASC',
)
return stmt.all(depends_on_task_id) as TaskDependencyRecord[]
}
}