20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
66 lines
2.1 KiB
TypeScript
Executable File
66 lines
2.1 KiB
TypeScript
Executable File
/**
|
|
* C5 regression: CapabilityTrustLevel wrong enum values
|
|
* Bug: used core/trusted/untrusted (3 values) instead of spec's 5-level hierarchy.
|
|
* Fix: import CapabilityTrustLevel from contracts, use 5 values.
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { CapabilityManifestValidator } from '../../src/capabilities/CapabilityManifestValidator.js'
|
|
import { readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
describe('C5: CapabilityTrustLevel 5-level enum', () => {
|
|
const src = readFileSync(
|
|
join(import.meta.dir, '..', '..', 'src', 'capabilities', 'CapabilityManifestValidator.ts'),
|
|
'utf-8'
|
|
)
|
|
|
|
it('imports CapabilityTrustLevel from contracts', () => {
|
|
expect(src).toContain('CapabilityTrustLevel')
|
|
expect(src).toContain('@aircoding/contracts')
|
|
})
|
|
|
|
it('TRUST_LEVELS contains all 5 spec values', () => {
|
|
const match = src.match(/TRUST_LEVELS[^=]*=\s*\[([^\]]+)\]/)
|
|
expect(match).not.toBeNull()
|
|
const levels = match![1]
|
|
expect(levels).toContain('built_in')
|
|
expect(levels).toContain('project_local')
|
|
expect(levels).toContain('user_installed')
|
|
expect(levels).toContain('verified_publisher')
|
|
expect(levels).toContain('untrusted')
|
|
})
|
|
|
|
it('TRUST_LEVELS does not contain legacy values', () => {
|
|
const match = src.match(/TRUST_LEVELS[^=]*=\s*\[([^\]]+)\]/)
|
|
expect(match).not.toBeNull()
|
|
const levels = match![1]
|
|
expect(levels).not.toContain("'core'")
|
|
expect(levels).not.toContain("'trusted'")
|
|
})
|
|
|
|
it('validate accepts manifest with trust_level=built_in', () => {
|
|
const validator = new CapabilityManifestValidator()
|
|
const result = validator.validate({
|
|
schema_version: 1,
|
|
name: 'test-cap',
|
|
version: '1.0.0',
|
|
tools: [],
|
|
trust_level: 'built_in',
|
|
})
|
|
expect(result.valid).toBe(true)
|
|
})
|
|
|
|
it('validate rejects manifest with trust_level=core', () => {
|
|
const validator = new CapabilityManifestValidator()
|
|
const result = validator.validate({
|
|
schema_version: 1,
|
|
name: 'test-cap',
|
|
version: '1.0.0',
|
|
tools: [],
|
|
trust_level: 'core',
|
|
})
|
|
expect(result.valid).toBe(false)
|
|
})
|
|
})
|