20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
47 lines
1.5 KiB
TypeScript
Executable File
47 lines
1.5 KiB
TypeScript
Executable File
/**
|
|
* A7 regression: DeveloperLogEncryptor — no dev-key fallback
|
|
* Bug: constructor fell back to 'dev-key' when no key provided, producing weak encryption.
|
|
* Fix: throws Error if no key is available.
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { DeveloperLogEncryptor } from '../../src/logging/DeveloperLogEncryptor.js'
|
|
import { join } from 'path'
|
|
import { tmpdir } from 'os'
|
|
|
|
describe('A7: DeveloperLogEncryptor no dev-key fallback', () => {
|
|
it('throws when no key is provided and env var is unset', () => {
|
|
const orig = process.env.AIRCODING_PROJECT_KEY
|
|
delete process.env.AIRCODING_PROJECT_KEY
|
|
|
|
try {
|
|
expect(() => {
|
|
new DeveloperLogEncryptor(join(tmpdir(), 'test-air-no-key'))
|
|
}).toThrow()
|
|
} finally {
|
|
if (orig !== undefined) {
|
|
process.env.AIRCODING_PROJECT_KEY = orig
|
|
}
|
|
}
|
|
})
|
|
|
|
it('succeeds when explicit key is provided', () => {
|
|
expect(() => {
|
|
new DeveloperLogEncryptor(join(tmpdir(), 'test-air-with-key'), 'test-key-123')
|
|
}).not.toThrow()
|
|
})
|
|
|
|
it('encrypts and decrypts round-trip correctly', () => {
|
|
const path = join(tmpdir(), 'test-air-roundtrip')
|
|
const encryptor = new DeveloperLogEncryptor(path, 'roundtrip-test-key')
|
|
|
|
encryptor.write({ level: 'debug', message: 'test entry' })
|
|
const entries = encryptor.read()
|
|
|
|
expect(entries.length).toBeGreaterThan(0)
|
|
const last = entries[entries.length - 1]
|
|
expect(last.message).toBe('test entry')
|
|
expect(last.level).toBe('debug')
|
|
})
|
|
})
|