20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
65 lines
2.5 KiB
TypeScript
Executable File
65 lines
2.5 KiB
TypeScript
Executable File
/**
|
|
* D3 regression: Worker result WorkerResult<T> envelope
|
|
* Validates that WorkerManager has the result field on WorkerHandle,
|
|
* wrap_worker_result and get_result methods, and imports WorkerResult
|
|
* from contracts.
|
|
*
|
|
* Uses source inspection (reading the source file as text).
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
const source_path = join(import.meta.dir, '../../src/workers/WorkerManager.ts')
|
|
const source = readFileSync(source_path, 'utf-8')
|
|
|
|
describe('D3: Worker result envelope', () => {
|
|
it('WorkerHandle has result field', () => {
|
|
expect(source).toContain('result?: WorkerResult<unknown>')
|
|
})
|
|
|
|
it('wrap_worker_result method exists', () => {
|
|
expect(source).toContain('wrap_worker_result(')
|
|
// Should be a private method
|
|
expect(source).toContain('private wrap_worker_result')
|
|
})
|
|
|
|
it('get_result method exists', () => {
|
|
expect(source).toContain('get_result(agent_id: string)')
|
|
// Should return WorkerResult<unknown> | undefined
|
|
expect(source).toContain('WorkerResult<unknown> | undefined')
|
|
})
|
|
|
|
it('imports WorkerResult from contracts', () => {
|
|
expect(source).toContain("import type { WorkerResult")
|
|
expect(source).toContain("from '@aircoding/contracts'")
|
|
})
|
|
|
|
it('imports WorkerStatus from contracts', () => {
|
|
expect(source).toContain('WorkerStatus')
|
|
})
|
|
|
|
it('imports AgentType from contracts', () => {
|
|
expect(source).toContain('AgentType')
|
|
})
|
|
|
|
it('wrap_worker_result returns WorkerResult with safe defaults', () => {
|
|
// Verify safe defaults for key fields
|
|
expect(source).toContain("agent_type: (payload.agent_type as AgentType) || 'executor'")
|
|
expect(source).toContain("status: (payload.status as WorkerStatus) || 'completed'")
|
|
expect(source).toContain("summary: (payload.summary as string) || ''")
|
|
expect(source).toContain('changed_files: (payload.changed_files as string[]) || []')
|
|
expect(source).toContain('artifacts: (payload.artifacts as any[]) || []')
|
|
expect(source).toContain('verification: (payload.verification as any[]) || []')
|
|
expect(source).toContain('risks: (payload.risks as any[]) || []')
|
|
expect(source).toContain('follow_up_tasks: (payload.follow_up_tasks as any[]) || []')
|
|
expect(source).toContain('evidence_refs: (payload.evidence_refs as any[]) || []')
|
|
})
|
|
|
|
it('get_result returns undefined for unknown agent', () => {
|
|
// The method should check if handle exists and return undefined
|
|
expect(source).toContain('if (!handle) return undefined')
|
|
})
|
|
})
|