20bad8ca29
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
53 lines
2.0 KiB
TypeScript
Executable File
53 lines
2.0 KiB
TypeScript
Executable File
/**
|
|
* A5+A4 regression: ToolRegistry permission fixes
|
|
* A5: ACTION_BRANCHES was module-level const — `this` was undefined in read_only/sandbox.
|
|
* Fix: moved to instance method execute_branch().
|
|
* A4: build_permission_context passed undefined for task_scope/permission_profile.
|
|
* Fix: passes context.task_scope and context.permission_profile.
|
|
*/
|
|
|
|
import { describe, it, expect } from 'bun:test'
|
|
import { readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
describe('A5+A4: ToolRegistry permission fixes', () => {
|
|
const src = readFileSync(
|
|
join(import.meta.dir, '..', '..', 'src', 'tools', 'ToolRegistry.ts'),
|
|
'utf-8'
|
|
)
|
|
|
|
it('does not have module-level ACTION_BRANCHES constant', () => {
|
|
expect(src).not.toMatch(/^const ACTION_BRANCHES/m)
|
|
})
|
|
|
|
it('has execute_branch as instance method', () => {
|
|
expect(src).toMatch(/execute_branch\s*\(/)
|
|
})
|
|
|
|
it('ToolExecutionContext includes task_scope field', () => {
|
|
const ctx_match = src.match(/interface ToolExecutionContext[^}]+}/s)
|
|
expect(ctx_match).not.toBeNull()
|
|
expect(ctx_match![0]).toContain('task_scope')
|
|
})
|
|
|
|
it('ToolExecutionContext includes permission_profile field', () => {
|
|
const ctx_match = src.match(/interface ToolExecutionContext[^}]+}/s)
|
|
expect(ctx_match).not.toBeNull()
|
|
expect(ctx_match![0]).toContain('permission_profile')
|
|
})
|
|
|
|
it('build_permission_context passes context.task_scope instead of undefined', () => {
|
|
const build_match = src.match(/private build_permission_context[^{]+\{[^}]+}/s)
|
|
expect(build_match).not.toBeNull()
|
|
expect(build_match![0]).toContain('context.task_scope')
|
|
expect(build_match![0]).not.toMatch(/task_scope:\s*undefined/)
|
|
})
|
|
|
|
it('build_permission_context passes context.permission_profile instead of undefined', () => {
|
|
const build_match = src.match(/private build_permission_context[^{]+\{[^}]+}/s)
|
|
expect(build_match).not.toBeNull()
|
|
expect(build_match![0]).toContain('context.permission_profile')
|
|
expect(build_match![0]).not.toMatch(/permission_profile:\s*undefined/)
|
|
})
|
|
})
|