System overview design: four-model audit, repair, and regression complete
- system-overview-design.md: repaired with P0/P1/P2 gaps resolved, all 24 frozen baselines listed, error taxonomy, global ~/.air, IPC, TaskSpec/WorkerResult, PromptLayer, PermissionEngine, RuntimeEvent, state machines, capability trust, artifact naming, operations - Four cross-verification audit reports (GPT-5, MIMO 2.5, Opus 4.7, DeepSeek V4 Pro) - Three regression reviews (R1: initial repair closure, R2: second pass with PromptLayer L9 wording found, R3: full PromptLayer alignment verified) - AGENTS.md, plan.md, todo.md synchronized Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
AirCoding
158
AirPlan/docs/architecture/概要设计修复回归审查-R3.md
Normal file
158
AirPlan/docs/architecture/概要设计修复回归审查-R3.md
Normal file
@@ -0,0 +1,158 @@
|
||||
# 概要设计修复回归审查（第三轮）
|
||||
|
||||
Date: 2026-05-29
|
||||
Reviewer: Independent third pass, clean session
|
||||
Status: Regression review after PromptLayer baseline alignment fix
|
||||
Scope: Verify continued closure of all P0/P1 and the PromptLayer rewrite is conflict-free
|
||||
|
||||
---
|
||||
|
||||
## 1. 触发原因
|
||||
|
||||
第二轮回归（R2）报告了 1 项 P2 措辞差异（PromptLayer L9），但用户对齐时发现实际差异覆盖 L3-L9 共 6 处。修复后 §13 已按 `prompt-layering-v1.md` §2 完整对齐。本轮回归独立核对：
|
||||
|
||||
1. PromptLayer 修复是否真正闭环？
|
||||
2. 修复是否引入与基线其它章节的新冲突？
|
||||
3. 之前两轮回归对 P0/P1/P2 的关闭结论是否仍然成立？
|
||||
4. 是否还有第三处隐藏的措辞/语义漂移？
|
||||
|
||||
---
|
||||
|
||||
## 2. 总体结论
|
||||
|
||||
**通过。**
|
||||
|
||||
- PromptLayer L0-L9 与基线 §2 措辞和顺序完全一致。
|
||||
- 未发现新的基线冲突。
|
||||
- 前两轮的 P0/P1/P2 关闭结论保持成立。
|
||||
- 经独立交叉核对，未发现新的隐藏漂移。
|
||||
- 概要设计仍处于可进入详细设计的就绪状态。
|
||||
|
||||
---
|
||||
|
||||
## 3. PromptLayer 闭环验证
|
||||
|
||||
逐层比对修复后 `system-overview-design.md` §13 与基线 `prompt-layering-v1.md` §2：
|
||||
|
||||
| 层 | 基线 §2 | 概要 §13 (修复后) | 匹配 |
|
||||
|---|---|---|---|
|
||||
| L0 | Runtime invariant | Runtime invariant | ✓ |
|
||||
| L1 | Role / agent mode | Role / agent mode | ✓ |
|
||||
| L2 | Safety and permission policy | Safety and permission policy | ✓ |
|
||||
| L3 | Project rules and user preferences | Project rules and user preferences | ✓ |
|
||||
| L4 | Architecture baseline and current plan | Architecture baseline and current plan | ✓ |
|
||||
| L5 | Task specification and acceptance criteria | Task specification and acceptance criteria | ✓ |
|
||||
| L6 | Relevant code/artifacts/evidence | Relevant code / artifacts / evidence | ✓ |
|
||||
| L7 | Recent conversation and decision context | Recent conversation and decision context | ✓ |
|
||||
| L8 | Tool result history / diagnostics | Tool result history / diagnostics | ✓ |
|
||||
| L9 | Immediate instruction | Immediate instruction | ✓ |
|
||||
|
||||
10/10 完全对齐。修复闭环成立。
|
||||
|
||||
附加说明：基线在 L0 单独标注 `Mutable: no, except by AirCoding release.`。这是详细设计可承载的层级元数据，概要设计未必逐项列出可变性属性。语义未丢失。
|
||||
|
||||
---
|
||||
|
||||
## 4. P0/P1/P2 关闭状态复核
|
||||
|
||||
按 R1、R2 的关闭清单逐项快速复核，确认本次 PromptLayer 修复未误伤其它已关闭项。
|
||||
|
||||
| 类别 | R1 关闭 | R2 关闭 | R3 复核 |
|
||||
|---|---|---|---|
|
||||
| P0 (10 项) | 10/10 | 10/10 | **10/10 保持** |
|
||||
| P1 (18 项) | 18/18 | 18/18 | **18/18 保持** |
|
||||
| P2 (非决策对齐项) | 全部 | 全部 | **全部保持** |
|
||||
|
||||
无回归。
|
||||
|
||||
---
|
||||
|
||||
## 5. 跨基线一致性独立抽查
|
||||
|
||||
本轮在 PromptLayer 之外独立抽查 7 处可能漂移点：
|
||||
|
||||
### 5.1 AgentType 枚举
|
||||
|
||||
- 基线 `interface-contracts-v1.md` §5: `"executor" | "reviewer" | "debugger" | "compactor" | "experience_miner"`（5 项）
|
||||
- 概要 §4/§7: Executor / Reviewer / Debugger / Compactor / ExperienceMiner（5 项）
|
||||
- 结论：一致
|
||||
|
||||
### 5.2 Worker exit codes
|
||||
|
||||
- 基线 `baselineV1.md` §8: 6 项（0-5）
|
||||
- 概要 §11: 6 项（0-5）
|
||||
- 结论：一致
|
||||
|
||||
### 5.3 Forbidden paths
|
||||
|
||||
- 基线 `interface-contracts-v1.md` §23: 10 项
|
||||
- 概要 §5: 11 项
|
||||
- 差异：概要新增 `runtime → TUI import`
|
||||
- 评估：这是 C4 module 依赖方向 `tui ← cli`、`runtime → contracts only` 的显式强化，并非新约束反向。属于细化，不构成冲突。
|
||||
- 结论：一致
|
||||
|
||||
### 5.4 ErrorKind 数量
|
||||
|
||||
- 基线 `interface-contracts-v1.md` §3: 22 种
|
||||
- 概要 §9.2: 22 种
|
||||
- 结论：一致
|
||||
|
||||
### 5.5 PathRisk 与 CommandRisk 分类
|
||||
|
||||
- 基线 `security-model-v1.md` §4-§5: 8 种 PathRisk + 10 种 CommandRisk
|
||||
- 概要 §12: 8 种 + 10 种
|
||||
- 结论：一致
|
||||
|
||||
### 5.6 Permission action 枚举
|
||||
|
||||
- 基线: `allow | deny | ask_user | block | refuse | announce_then_run`
|
||||
- 概要 §12: 同上
|
||||
- 结论：一致
|
||||
|
||||
### 5.7 ScopeImpactLevel
|
||||
|
||||
- 基线 `scope-escalation-v1.md` §2: 7 种
|
||||
- 概要 §10.7: 7 种（implementation/interface/architecture/product/permission/environment/policy）
|
||||
- 结论：一致
|
||||
|
||||
---
|
||||
|
||||
## 6. 三轮回归对比
|
||||
|
||||
| 维度 | R1 | R2 | R3 |
|
||||
|---|---|---|---|
|
||||
| P0 关闭 | 10/10 | 10/10 | 10/10 |
|
||||
| P1 关闭 | 18/18 | 18/18 | 18/18 |
|
||||
| P2 非决策项 | 全部 | 全部 | 全部 |
|
||||
| 新发现 | 0 | 1（PromptLayer L9） | 0 |
|
||||
| 新引入冲突 | 0 | 0 | 0 |
|
||||
| 修复后是否新增漂移 | — | — | 否 |
|
||||
|
||||
R2 发现的 1 项已在 R2→R3 之间修复并经 R3 独立验证闭环。R3 未发现新增问题。
|
||||
|
||||
---
|
||||
|
||||
## 7. 门禁判定
|
||||
|
||||
| 门禁 | R3 状态 |
|
||||
|---|---|
|
||||
| P0 全部关闭 | PASS |
|
||||
| P1 全部覆盖 | PASS |
|
||||
| 非决策 P2 处理 | PASS |
|
||||
| PromptLayer 与基线对齐 | PASS |
|
||||
| 跨基线抽查无冲突 | PASS |
|
||||
| 可进入详细设计 | **PASS** |
|
||||
|
||||
最终结论：**第三轮回归通过。** 概要设计可进入详细设计 / 类图冻结 / `packages/contracts` 转写。
|
||||
|
||||
---
|
||||
|
||||
## 8. 后续建议
|
||||
|
||||
为避免再次出现 PromptLayer 这类多层措辞漂移，详细设计阶段建议：
|
||||
|
||||
1. 详细设计文档凡引用基线枚举/层名，应直接复制基线原文措辞，而非概述。
|
||||
2. 类图冻结阶段对每个枚举类型做最后一次"概览—基线—contracts 包"三方比对。
|
||||
3. 增加一项详细设计释义机制：当详细设计需要扩写概要描述时，在脚注或附录中标注与基线原文的对齐方式。
|
||||
|
||||
这些是流程建议，不阻塞进入详细设计。
|
||||
Reference in New Issue
Block a user