fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
45
packages/runtime/test/regression/workspace-enum.test.ts
Executable file
45
packages/runtime/test/regression/workspace-enum.test.ts
Executable file
@@ -0,0 +1,45 @@
|
||||
/**
|
||||
* A2 regression: Workspace enum crash
|
||||
* Bug: EventStore used 'created' and 'merging' which are not valid workspace statuses.
|
||||
* Valid: 'active' | 'merged' | 'abandoned' | 'cleaned'
|
||||
* Fix: 'created' → 'active'; 'merging' → metadata-only update (no status change).
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'bun:test'
|
||||
import { readFileSync } from 'fs'
|
||||
import { join } from 'path'
|
||||
|
||||
describe('A2: Workspace enum values', () => {
|
||||
const event_store_src = readFileSync(
|
||||
join(import.meta.dir, '..', '..', 'src', 'events', 'EventStore.ts'),
|
||||
'utf-8'
|
||||
)
|
||||
|
||||
it('workspace.created projection uses status active, not created', () => {
|
||||
const created_block = event_store_src.match(/case 'workspace\.created'[^}]+}/s)
|
||||
expect(created_block).not.toBeNull()
|
||||
expect(created_block![0]).toContain("status: 'active'")
|
||||
expect(created_block![0]).not.toContain("status: 'created'")
|
||||
})
|
||||
|
||||
it('workspace.merge.started does not set invalid merging status', () => {
|
||||
const merge_block = event_store_src.match(/case 'workspace\.merge\.started'[^}]+}/s)
|
||||
expect(merge_block).not.toBeNull()
|
||||
expect(merge_block![0]).not.toContain("status: 'merging'")
|
||||
})
|
||||
|
||||
it('WorkspaceManager state type only allows valid values', () => {
|
||||
const ws_src = readFileSync(
|
||||
join(import.meta.dir, '..', '..', 'src', 'scheduler', 'WorkspaceManager.ts'),
|
||||
'utf-8'
|
||||
)
|
||||
const state_match = ws_src.match(/state:\s*'([^']+)'/g)
|
||||
if (state_match) {
|
||||
const valid = ['active', 'merged', 'abandoned', 'cleaned']
|
||||
for (const m of state_match) {
|
||||
const val = m.match(/'([^']+)'/)?.[1]
|
||||
if (val) expect(valid).toContain(val)
|
||||
}
|
||||
}
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user