fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
57
packages/runtime/test/regression/tool-stubs.test.ts
Executable file
57
packages/runtime/test/regression/tool-stubs.test.ts
Executable file
@@ -0,0 +1,57 @@
|
||||
/**
|
||||
* C7 regression: Register 5 missing high-priority tools
|
||||
* Validates that BuiltInToolRegistrar registers fs.stat, cpp.build,
|
||||
* cpp.test, cpp.static.cppcheck, and debug.run stub tools.
|
||||
*
|
||||
* Uses source inspection (reading the source file as text).
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'bun:test'
|
||||
import { readFileSync } from 'fs'
|
||||
import { join } from 'path'
|
||||
|
||||
const source_path = join(import.meta.dir, '../../src/tools/BuiltInToolRegistrar.ts')
|
||||
const source = readFileSync(source_path, 'utf-8')
|
||||
|
||||
describe('C7: Stub tool registrations', () => {
|
||||
const stub_tools = [
|
||||
{ name: 'fs.stat', category: 'filesystem' },
|
||||
{ name: 'cpp.build', category: 'build' },
|
||||
{ name: 'cpp.test', category: 'test' },
|
||||
{ name: 'cpp.static.cppcheck', category: 'static_analysis' },
|
||||
{ name: 'debug.run', category: 'debug' },
|
||||
]
|
||||
|
||||
for (const tool of stub_tools) {
|
||||
it(`registers ${tool.name} tool`, () => {
|
||||
// Check that the tool name appears in a stub definition
|
||||
expect(source).toContain(`name: '${tool.name}'`)
|
||||
expect(source).toContain(`category: '${tool.category}'`)
|
||||
})
|
||||
}
|
||||
|
||||
it('stub executors have not_implemented error type', () => {
|
||||
// Verify the stub executor returns not_implemented error
|
||||
expect(source).toContain("error_type: 'not_implemented'")
|
||||
expect(source).toContain("message: 'TODO: implement'")
|
||||
})
|
||||
|
||||
it('stub executors return error type envelope', () => {
|
||||
expect(source).toContain("type: 'error'")
|
||||
expect(source).toContain("call_id: ''")
|
||||
})
|
||||
|
||||
it('create_stub_definitions method exists', () => {
|
||||
expect(source).toContain('create_stub_definitions()')
|
||||
})
|
||||
|
||||
it('create_stub_executor method exists', () => {
|
||||
expect(source).toContain('create_stub_executor(')
|
||||
})
|
||||
|
||||
it('stub tools are registered via register_tool in register_all', () => {
|
||||
// Verify the stub registration loop exists in register_all
|
||||
expect(source).toContain('stub_definitions')
|
||||
expect(source).toContain('create_stub_executor(name)')
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user