fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
33
packages/runtime/test/regression/command-risk-analyzer.test.ts
Executable file
33
packages/runtime/test/regression/command-risk-analyzer.test.ts
Executable file
@@ -0,0 +1,33 @@
|
||||
/**
|
||||
* A8 regression: CommandRiskAnalyzer `in` operator bug
|
||||
* 'sudo_likely' in string was always false (checks String prototype).
|
||||
* Fixed to use string.includes('sudo').
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'bun:test'
|
||||
import { CommandRiskAnalyzer } from '../../src/security/CommandRiskAnalyzer.js'
|
||||
|
||||
describe('A8: CommandRiskAnalyzer sudo detection', () => {
|
||||
const analyzer = new CommandRiskAnalyzer('/tmp/test-project')
|
||||
|
||||
it('detects sudo in system modification commands', () => {
|
||||
const result = analyzer.analyze('sudo apt install vim')
|
||||
expect(result.flags).toContain('intent_sudo')
|
||||
expect(result.flags).not.toContain('system_command')
|
||||
})
|
||||
|
||||
it('flags non-sudo system commands as system_command', () => {
|
||||
const result = analyzer.analyze('apt install vim')
|
||||
expect(result.flags).toContain('system_command')
|
||||
})
|
||||
|
||||
it('detects sudo in standalone usage', () => {
|
||||
const result = analyzer.analyze('sudo ls /etc')
|
||||
expect(result.flags).toContain('intent_sudo')
|
||||
})
|
||||
|
||||
it('does not falsely flag commands without sudo', () => {
|
||||
const result = analyzer.analyze('ls -la')
|
||||
expect(result.flags).not.toContain('intent_sudo')
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user