fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -60,8 +60,8 @@ export class TaskAttemptRepository implements Repository<TaskAttemptRecord, Task
|
||||
/**
|
||||
* Get a task attempt by ID.
|
||||
*/
|
||||
async get(id: UUID, _tx?: TransactionHandle): Promise<TaskAttemptRecord | undefined> {
|
||||
const stmt = this.db.prepare('SELECT * FROM task_attempts WHERE id = ?')
|
||||
async get(id: UUID, tx?: TransactionHandle): Promise<TaskAttemptRecord | undefined> {
|
||||
const stmt = (tx?.db ?? this.db).prepare('SELECT * FROM task_attempts WHERE id = ?')
|
||||
const row = stmt.get(id) as TaskAttemptRecord | undefined
|
||||
return row
|
||||
}
|
||||
@@ -69,11 +69,11 @@ export class TaskAttemptRepository implements Repository<TaskAttemptRecord, Task
|
||||
/**
|
||||
* Insert a new task attempt. Status is set by EventStore projection (INV-1).
|
||||
*/
|
||||
async insert(record: TaskAttemptInsert, _tx?: TransactionHandle): Promise<void> {
|
||||
async insert(record: TaskAttemptInsert, tx?: TransactionHandle): Promise<void> {
|
||||
// Status is set by EventStore.project(), not by caller
|
||||
const status: TaskAttemptStatus = 'pending'
|
||||
|
||||
const stmt = this.db.prepare(`
|
||||
const stmt = (tx?.db ?? this.db).prepare(`
|
||||
INSERT INTO task_attempts (
|
||||
id, session_id, task_id, attempt_index,
|
||||
agent_id, status,
|
||||
@@ -102,7 +102,7 @@ export class TaskAttemptRepository implements Repository<TaskAttemptRecord, Task
|
||||
/**
|
||||
* Update an existing task attempt. Status changes only via EventStore projection (INV-1).
|
||||
*/
|
||||
async update(id: UUID, patch: TaskAttemptUpdate, _tx?: TransactionHandle): Promise<void> {
|
||||
async update(id: UUID, patch: TaskAttemptUpdate, tx?: TransactionHandle): Promise<void> {
|
||||
const fields: string[] = []
|
||||
const values: unknown[] = []
|
||||
|
||||
@@ -112,6 +112,10 @@ export class TaskAttemptRepository implements Repository<TaskAttemptRecord, Task
|
||||
values.push(patch.agent_id)
|
||||
}
|
||||
if (patch.failure_signature !== undefined) {
|
||||
fields.push('failure_signature = ?')
|
||||
values.push(patch.failure_signature)
|
||||
}
|
||||
if (patch.failure_summary !== undefined) {
|
||||
fields.push('failure_summary = ?')
|
||||
values.push(patch.failure_summary)
|
||||
}
|
||||
@@ -133,7 +137,7 @@ export class TaskAttemptRepository implements Repository<TaskAttemptRecord, Task
|
||||
}
|
||||
|
||||
values.push(id)
|
||||
const stmt = this.db.prepare(`UPDATE task_attempts SET ${fields.join(', ')} WHERE id = ?`)
|
||||
const stmt = (tx?.db ?? this.db).prepare(`UPDATE task_attempts SET ${fields.join(', ')} WHERE id = ?`)
|
||||
stmt.run(...values)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user