fix(P0): close 15 blockers + add 26 regression tests; fix wiring schema regression
Phase A (security red lines) — CLOSED: - B8: 3x command injection fixed (execFileSync + args array in CMake/CppBuilder/Cppcheck) - B6: ToolRegistry permission bypass fixed (real task_scope/profile passed) - B7: ACTION_BRANCHES this-binding crash fixed (instance method) - B17: DeveloperLogEncryptor hardcoded 'dev-key' removed (throws if no key) - B22: CommandRiskAnalyzer 'in' operator bug fixed (includes) - B1: EventStore.project() transaction handle now passed to all repos - B2: workspace projection illegal enum fixed (active/merged) - B4: route_prefix separator unified to '/' - B5: TaskAttempt column mapping fixed Other blockers fixed: - B3: project-level DB schema aligned to db-schema §20 (.air/local, learned_memories) - B9: cpp.* tools registered through PermissionEngine path - B11: Scheduler BLOCKED/CANCELLED states added - B18: CapabilityTrustLevel 5-level enum aligned - B19: PermissionEngine block/refuse/announce_then_run + grant_scope - B20: Worker exit code 4 = parent_cancelled - B24: project_id now randomUUID Regression fix (introduced by B3 schema refactor): - wiring.ts capture_debug_record/promote_memory_entry realigned to refactored DebugRecord/MemoryEntry interfaces (was compile-level decoupling) Tests: 128 regression/unit tests pass (22 regression + 3 unit + 3 e2e suites) Still open (tracked for next round): B10 (INV-2 outbox emit), B12 (Scheduler event projection), B13 (MainAgent LLM classify), B14 (IPC envelope fields), B15 (TUI OpenTUI), B16 (api_key strict), B21 (CLI init INV-3), B23 (e2e real), B25 (MVP tools), B26 (ContextAssembler L6-L9) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
51
packages/llm/test/model-config-loader.test.ts
Executable file
51
packages/llm/test/model-config-loader.test.ts
Executable file
@@ -0,0 +1,51 @@
|
||||
/**
|
||||
* A7 regression: ModelConfigLoader auth_ref + api_key deprecation
|
||||
* Bug: api_key stored plaintext in YAML config.
|
||||
* Fix: added auth_ref field; api_key triggers deprecation warning.
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'bun:test'
|
||||
import { ModelConfigLoader } from '../src/ModelConfigLoader.js'
|
||||
import { writeFileSync, mkdirSync, rmSync, existsSync } from 'fs'
|
||||
import { join } from 'path'
|
||||
import { tmpdir } from 'os'
|
||||
|
||||
describe('A7: ModelConfigLoader auth_ref', () => {
|
||||
const test_dir = join(tmpdir(), 'test-model-config-' + Date.now())
|
||||
|
||||
it('loads auth_ref from YAML config', () => {
|
||||
mkdirSync(test_dir, { recursive: true })
|
||||
const config_path = join(test_dir, 'models.yaml')
|
||||
writeFileSync(config_path, [
|
||||
'test-model:',
|
||||
' provider: anthropic',
|
||||
' model: claude-3',
|
||||
' auth_ref: env:ANTHROPIC_API_KEY',
|
||||
].join('\n'))
|
||||
|
||||
const loader = new ModelConfigLoader(config_path)
|
||||
const config = loader.get_model('test-model')
|
||||
|
||||
expect(config).not.toBeUndefined()
|
||||
expect(config!.auth_ref).toBe('env:ANTHROPIC_API_KEY')
|
||||
expect(config!.provider).toBe('anthropic')
|
||||
|
||||
rmSync(test_dir, { recursive: true, force: true })
|
||||
})
|
||||
|
||||
it('validates config with auth_ref succeeds', () => {
|
||||
const loader = new ModelConfigLoader()
|
||||
const result = loader.validate({
|
||||
provider: 'anthropic',
|
||||
model: 'claude-3',
|
||||
auth_ref: 'env:ANTHROPIC_API_KEY',
|
||||
})
|
||||
expect(result.valid).toBe(true)
|
||||
})
|
||||
|
||||
it('validate requires provider and model', () => {
|
||||
const loader = new ModelConfigLoader()
|
||||
expect(loader.validate({ provider: '', model: 'x' } as any).valid).toBe(false)
|
||||
expect(loader.validate({ provider: 'x', model: '' } as any).valid).toBe(false)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user